adjust rediscluster constant options#921
Open
mocxi wants to merge 1 commit intoPHPSocialNetwork:masterfrom
Open
adjust rediscluster constant options#921mocxi wants to merge 1 commit intoPHPSocialNetwork:masterfrom
mocxi wants to merge 1 commit intoPHPSocialNetwork:masterfrom
Conversation
Member
|
Nice catch, thanks ! |
Member
|
Can you run the tests locally and tell me if they work successfully ? |
Author
|
Hello, /**
* Check RedisCluster working
*/
#[Group('skip')]
#[Group('rawconfig')]
public function testRawConfig()
{
$config = new \Phpfastcache\Drivers\Rediscluster\Config();
$config->addCluster('redis-node-creator:6379');
$cache = CacheManager::getInstance('RedisCluster', $config);
$testString = 'xxx';
$cacheKey = sha1('test');
$cacheString = $cache->getItem($cacheKey)->set($testString);
$cacheString->expiresAfter(5);
$cache->save($cacheString);
$value = $cache->getItem($cacheKey)->get();
$this->assertEquals($value, $testString);
}about the failed test above I see the error: I guess the issue is that the RedisCluster server is not working properly. |
Member
|
Hi @mocxi can you fix the CI errors + add check of constant before using them to keep backward compatibility please ? Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
update constants which we're using for the RedisCluster option were removed: phpredis/phpredis#2262
Types of changes
What types of changes does your code introduce to Phpfastcache?
Put an
xin the boxes that applyAgreement
I have read the CONTRIBUTING and CODING GUIDELINE docs
Further comments
N/A