fix: var_temp indices are no longer referenced in call assignment#1617
Merged
Angus-Bethke-Bachmann merged 13 commits intomasterfrom Mar 19, 2026
Merged
fix: var_temp indices are no longer referenced in call assignment#1617Angus-Bethke-Bachmann merged 13 commits intomasterfrom
Angus-Bethke-Bachmann merged 13 commits intomasterfrom
Conversation
mhasel
requested changes
Mar 16, 2026
Member
There was a problem hiding this comment.
I found two remaining edge cases - I've pushed failing tests that showcase them.
function_block_with_var_temp_should_compile_when_output_has_direct_access- panics atexpression_generator.rs:942, wherebuild_struct_gepstill uses the raw position.function_block_with_var_temp_before_input_should_compile- compiles but emitsi32 1instead ofi32 0for theGEPof an input parameter declared after aVAR_TEMPblock.
The second test includes an inline snapshot of the correct expected IR so the failure shows a clear diff.
To verify, please also add LIT tests for both cases.
mhasel
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Testing