-
Notifications
You must be signed in to change notification settings - Fork 9
[refactor] Separate noise filtering and centralize noise file detection #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors “noise file” filtering in the client inventory pipeline by centralizing filename matching into a dedicated NoiseFileDetector, expanding the known noise-file set, and documenting the list/behavior.
Changes:
- Added
NoiseFileDetectorwith centralized OS-dependent (Linux case-sensitive vs non-Linux case-insensitive) filename matching. - Updated
FileSystemInspector.IsNoiseFileName(...)to delegate to the detector. - Added/updated unit tests and introduced a spec doc enumerating known noise files and matching rules.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/ByteSync.Client/Services/Inventories/NoiseFileDetector.cs |
New centralized noise-file detection logic and expanded known-name list. |
src/ByteSync.Client/Services/Inventories/FileSystemInspector.cs |
Delegates noise filename detection to NoiseFileDetector. |
tests/ByteSync.Client.UnitTests/Services/Inventories/NoiseFileDetectorTests.cs |
New unit tests for detector behavior across OS + casing rules. |
tests/ByteSync.Client.UnitTests/Services/Inventories/FileSystemInspectorTests.cs |
Adds focused tests validating inspector noise-file behavior. |
docs/specs/SPEC-noise-file-detection.md |
Documents the known noise-file list and OS-specific matching behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/ByteSync.Client.UnitTests/Services/Inventories/NoiseFileDetectorTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|



Summary:
This PR completes the refactor around noise-file filtering in inventory analysis by centralizing detection logic and extending the known noise-file list while preserving existing session behavior.
Key changes:
NoiseFileDetectorto centralize noise-file matching in one place.FileSystemInspector.IsNoiseFileName(...)to delegate toNoiseFileDetector.FileSystemInspectortests for noise-file behavior.docs/specs/SPEC-noise-file-detection.mdwith file origin by platform.Implementation approach:
SessionSettings.ExcludeSystemFiles.Notes/risks:
ByteSync.Functions.IntegrationTestsbecause Docker is unavailable; client unit/integration tests related to this change pass.