-
Notifications
You must be signed in to change notification settings - Fork 9
[feature] Extend noise entry detection for issue 265 #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Extends the client inventory “exclude system files” feature to treat additional OS-generated entries as noise (including directories) and updates the corresponding tests and specification.
Changes:
- Expanded the embedded noise entries list (e.g.,
$RECYCLE.BIN,.AppleDB,.AppleDesktop). - Added inventory traversal logic to skip non-root noise directories and record them as skipped entries.
- Renamed skip reason from
NoiseFiletoNoiseEntryand updated unit tests + spec.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ByteSync.Client.UnitTests/Services/Inventories/NoiseFileDetectorTests.cs | Adds new test cases for the expanded noise entries list and case-sensitivity behavior. |
| tests/ByteSync.Client.UnitTests/Services/Inventories/InventoryBuilderInspectorTests.cs | Updates skip reason expectations and adds coverage for skipping noise child directories while still analyzing noise root directories. |
| src/ByteSync.Client/Services/Inventories/noise-files.json | Adds additional noise entries to the embedded resource list. |
| src/ByteSync.Client/Services/Inventories/InventoryBuilder.cs | Implements non-root noise directory filtering and updates file noise skip reason to NoiseEntry. |
| src/ByteSync.Client/Models/Inventories/SkipReason.cs | Renames NoiseFile enum value to NoiseEntry. |
| docs/specs/SPEC-noise-file-detection.md | Updates the spec to reflect the expanded noise list and matching behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|



Summary
This PR completes issue #265 by extending noise entry handling in inventory analysis.
Key changes
$RECYCLE.BIN,.AppleDB,.AppleDesktop).NoiseFiletoNoiseEntryto cover both files and directories.Notes/Risks
Closes #265