support to pass ROBOT_INITIAL_POSE via argument, in addition to environment#147
Open
k-okada wants to merge 1 commit intoPR2:kinetic-develfrom
Open
support to pass ROBOT_INITIAL_POSE via argument, in addition to environment#147k-okada wants to merge 1 commit intoPR2:kinetic-develfrom
k-okada wants to merge 1 commit intoPR2:kinetic-develfrom
Conversation
k-okada
added a commit
to k-okada/jsk_demos
that referenced
this pull request
May 22, 2020
048a4cd to
3cda008
Compare
3cda008 to
557b61d
Compare
k-okada
added a commit
to k-okada/jsk_demos
that referenced
this pull request
May 23, 2020
v4hn
approved these changes
May 23, 2020
Member
v4hn
left a comment
There was a problem hiding this comment.
Does this really work?
pr2.launch uses pass_all_args, but the documentation of this argument (I'd never heard of it before) makes it sound like pr2.launch should at least define the argument and only forwarding it in <include> can be omitted. Otherwise launch file sanitizers will have a harder time figuring out whether arguments are actually used..
If that's just a misunderstanding on my end, feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allow user to write
and it will not break current usage: