feat: add 'array_agg', 'max_by' function#5748
Draft
sunyeongchoi wants to merge 3 commits intoPRQL:mainfrom
Draft
feat: add 'array_agg', 'max_by' function#5748sunyeongchoi wants to merge 3 commits intoPRQL:mainfrom
sunyeongchoi wants to merge 3 commits intoPRQL:mainfrom
Conversation
…he maximum value of another expression
778d5f1 to
44a2648
Compare
Member
|
Hi @sunyeongchoi , Thank you for the PRs! I'm busy catching up on resolving some of the stale PRs and then will hopefully get to reviewing these soon. |
64338b9 to
8124cbf
Compare
Member
|
the array functions require much more thought and language design. I think we can add functions for scalar functions, but we should not add array functions through this process hope that's OK @sunyeongchoi ! I would welcome more scalar functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #5747
array_agg
max_by