Conversation
Update inline snapshot string delimiters (@r" -> @", r### -> r#) and remove deprecated snapshot_kind: text metadata from snap files. All changes are format-only with no semantic differences. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Non-format changes from insta snapshot regeneration: - compile/fmt append_select_nulls.snap: expression field corrected to match current .prql file (stale '# duckdb:skip' / '# postgres:skip' comments were removed from the file in a prior commit but the snap metadata was never regenerated) - compileall snap files: leading blank lines added to snapshot content. Each blank line represents a dialect whose output matches the generic dialect (empty diff). The previous insta version trimmed these; the new version preserves them. The actual diff content is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
great! will look at the snapshot issue @prql-bot are you online?! |
|
I'm online! 👋 Regarding @snth's question about the CI failure on c971aff — the failure is not related to the snapshot changes. It's a Docker Hub authentication error in the This is an infrastructure/credentials issue pulling the postgres container image. All the actual Rust tests, lints, builds, and code coverage checks passed successfully. A re-run of that job should fix it (assuming Docker Hub credentials are refreshed or the rate limit clears). |
Authenticate with Docker Hub before pulling images to avoid rate limits. - test-rust.yaml: login before docker compose up (postgres, mysql, clickhouse) - build-devcontainer.yaml: login before image builds as defensive measure Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Docker Hub login step in test-rust and build-devcontainer workflows needs access to DOCKERHUB_USERNAME and DOCKERHUB_TOKEN secrets. These are only available via 'secrets: inherit' on workflow_call invocations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@max-sixty I set up the Docker Hub account and added the details to the repo secrets. Should be good to merge now. |
|
@prql-bot can you do a follow-up to change the code that produces those snapshots to avoid producing the blank lines at the top? fix at the source please |
|
thanks @snth ! |
Skip empty diffs (where dialect output matches generic) instead of including them, which produced leading/intermediate blank lines in the snapshot files. Closes follow-up from #5750. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Done — opened #5752 to fix this at the source. The |
3 participants
Force-update all integration test snapshots to current insta format. The newer insta (1.46.3) enforces a stricter snapshot format, causing CI to fail with 'existing value is in a legacy format'.