Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build action to wrap the PowerShell command in a multiline script, explicitly capture the module version from the environment, and add a log statement for that version.
- Convert single-line
runinto a multiline PowerShell script - Assign and log
ModuleVersionbefore packaging - Preserve original
./build.ps1 -tasks packinvocation
Comments suppressed due to low confidence (2)
.github/actions/build/action.yml:51
- Write-Verbose messages are hidden by default in GitHub Actions logs unless -Verbose is enabled; consider using Write-Host for consistent output of the module version.
Write-Verbose "Using version: $ModuleVersion" -Verbose
.github/actions/build/action.yml:50
- [nitpick] Assigning $Env:ModuleVersion to a local variable is redundant; you can reference $Env:ModuleVersion directly to simplify the script.
$ModuleVersion = $Env:ModuleVersion
Contributor
Linux Test Results 1 files 16 suites 4s ⏱️ For more details on these failures, see this check. Results for commit 0800f9d. |
Contributor
Win Test Results 1 files 16 suites 6s ⏱️ For more details on these failures, see this check. Results for commit 0800f9d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.