Skip to content

[Cherry-Pick][Feature]distinguish whl version(#7204)#7223

Merged
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:release/2.5from
EmmonsCurse:cherry-pick/7204/release/2.5
Apr 7, 2026
Merged

[Cherry-Pick][Feature]distinguish whl version(#7204)#7223
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:release/2.5from
EmmonsCurse:cherry-pick/7204/release/2.5

Conversation

@EmmonsCurse
Copy link
Copy Markdown
Collaborator

Cherry-pick of #7204 (authored by @ChowMingSing) to release/2.5.

devPR:#7204


Motivation

rename whl

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
  • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
  • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link
Copy Markdown

paddle-bot bot commented Apr 7, 2026

Thanks for your contribution!

* [Feature]whl version

* [Feature]whl version,set root_is_pure = false

* [Feature]code style
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/2.5@22a217f). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release/2.5    #7223   +/-   ##
==============================================
  Coverage               ?   68.83%           
==============================================
  Files                  ?      390           
  Lines                  ?    54360           
  Branches               ?     8570           
==============================================
  Hits                   ?    37421           
  Misses                 ?    14233           
  Partials               ?     2706           
Flag Coverage Δ
GPU 68.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jiang-Jia-Jun Jiang-Jia-Jun merged commit 2d6fa35 into PaddlePaddle:release/2.5 Apr 7, 2026
34 of 38 checks passed
Copy link
Copy Markdown

@fastdeploy-bot fastdeploy-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Code Review | 2026-04-08

📋 Review 摘要

PR 概述:修改 wheel 打包配置,从生成纯 Python 包 (py3-none-any) 改为平台相关包(动态获取 Python/ABI/Platform 标签)

变更范围:setup.py

影响面 Tag[CI]

PR 规范检查

  • ✅ 标题包含有效 Tag:[Cherry-Pick][Feature]
  • ✅ Cherry-pick PR 已注明原 PR 链接 (#7204)

发现的问题

级别 文件 概述
🟡 建议 setup.py:26 新增的 packaging 依赖未显式声明为构建时依赖

总体评价

此变更将 wheel 从纯 Python 包改为平台相关包,使包名能够区分不同的 Python 版本和平台,这是合理且必要的改进。代码实现简洁正确,但建议显式声明构建时依赖以确保构建环境的一致性。

from pathlib import Path

import paddle
from packaging import tags
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 建议 新增的 packaging 依赖未显式声明为构建时依赖。

setup.py 中新增了 from packaging import tags 导入,但 packaging 未在以下位置声明:

  • pyproject.tomlbuild-system.requires
  • setup()setup_requires 参数

虽然 packaging 通常随 pip/setuptools 一起安装,但作为构建时依赖,建议显式声明以确保构建环境的一致性。

建议修复方式:
pyproject.toml 中添加构建系统配置:

[build-system]
requires = ["setuptools>=45", "packaging>=21.0"]
build-backend = "setuptools.build_meta"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants