[Cherry-Pick][Feature]distinguish whl version(#7204)#7224
[Cherry-Pick][Feature]distinguish whl version(#7204)#7224EmmonsCurse wants to merge 1 commit intoPaddlePaddle:release/2.6from
Conversation
|
Thanks for your contribution! |
* [Feature]whl version * [Feature]whl version,set root_is_pure = false * [Feature]code style
EmmonsCurse
force-pushed
the
cherry-pick/7204/release/2.6
branch
from
3358030 to
d80f99b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/2.6 #7224 +/- ##
==============================================
Coverage ? 73.26%
==============================================
Files ? 376
Lines ? 52886
Branches ? 8249
==============================================
Hits ? 38746
Misses ? 11432
Partials ? 2708
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fastdeploy-bot
left a comment
fastdeploy-bot
left a comment
There was a problem hiding this comment.
🤖 AI Code Review |
2026-04-08 10:48 CST
📋 Review 摘要
PR 概述：将 FastDeploy wheel 从纯 Python wheel（py3-none-any）改为平台特定 wheel（如 cp310-cp310-linux_x86_64），以便区分不同架构和 Python 版本的 whl 文件
变更范围：setup.py（打包构建配置）
影响面 Tag：[Feature]
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🟡 建议 | setup.py:45 |
类文档注释描述为"pure Python packages"，但实际变更后生成的是平台特定 wheel |
总体评价
这是一个从 develop 分支 cherry-pick 到 release/2.6 的 PR，代码逻辑正确。使用 packaging.tags 是 Python 打包的推荐做法，变更合理。未发现阻塞性问题。
|
|
||
|
|
||
| class CustomBdistWheel(bdist_wheel): | ||
| """Custom wheel builder for pure Python packages.""" |
There was a problem hiding this comment.
🟡 建议 类文档注释仍然描述为"Custom wheel builder for pure Python packages"，但实际变更后生成的是平台特定的 wheel（非纯 Python）。
建议更新文档注释以与实际行为一致：
class CustomBdistWheel(bdist_wheel):
"""Custom wheel builder for platform-specific packages."""5 participants
Cherry-pick of #7204 (authored by @ChowMingSing) to
release/2.6.devPR:#7204
Motivation
rename whl
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.