Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/_unit_test_coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,12 @@ jobs:
--sysctl kernel.msgmnb=268435456 \
--name ${runner_name} \
--cap-add=SYS_PTRACE --cap-add=IPC_LOCK \
--shm-size=64G \
--shm-size=128G \
${RDMA_DEVICES} \
--device=/dev/infiniband/rdma_cm \
--ulimit memlock=-1:-1 \
--ulimit nofile=65536:65536 \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 建议 PR 描述中的 Modifications 部分未涵盖此变更。

PR 描述仅提到了 shm-size 的增加,但未提及新增的这两个 --ulimit 配置。建议在 PR 描述中补充说明这些 ulimit 限制的作用,便于后续维护者理解变更背景。

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

--ulimit nproc=8192:8192 \
-v $(pwd):/workspace -w /workspace \
-v "${CACHE_DIR}/gitconfig:/etc/gitconfig:ro" \
-v "${CACHE_DIR}/.cache:/root/.cache" \
Expand Down
Loading