Skip to content

chore(jd): improve PlayerConnectionValidateLoginEvent#13591

Merged
Warriorrrr merged 3 commits intoPaperMC:mainfrom
Timongcraft:chore/improve-connection-login-validate-event-jd
Feb 26, 2026
Merged

chore(jd): improve PlayerConnectionValidateLoginEvent#13591
Warriorrrr merged 3 commits intoPaperMC:mainfrom
Timongcraft:chore/improve-connection-login-validate-event-jd

Conversation

@Timongcraft
Copy link
Copy Markdown
Contributor

This fact seems easy to miss and since now someone else in the Discord had the same problem, this should be documented.

@Timongcraft Timongcraft requested a review from a team as a code owner February 1, 2026 11:23
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Feb 1, 2026
Copy link
Copy Markdown
Member

@Warriorrrr Warriorrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I've considered adding before directly to the javadoc of getConnection, but listing what classes you can cast it to (what some could call a guarantee) seems contradictory to this note here:

Note, the type of this connection is not guaranteed to be stable across versions.

Would like to ask @Owen1212055 for his opinion on this

@Owen1212055
Copy link
Copy Markdown
Member

This api is very version specific, which is the issue.... as if mojang changes their protocol we cannot maintain compatability for people who are relying on certain behavior.

I agree with possibly improving the documentation, but we need to slap a big "this is as of X minecraft version, and may change".

@Timongcraft
Copy link
Copy Markdown
Contributor Author

should the tag be added to checkstyle or should I change the javadoc?

@Warriorrrr Warriorrrr merged commit 47aef92 into PaperMC:main Feb 26, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Awaiting review to Merged in Paper PR Queue Feb 26, 2026
@Timongcraft Timongcraft deleted the chore/improve-connection-login-validate-event-jd branch March 2, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants