Added menu sound effects for select and click actions#20
Open
harsh-k7 wants to merge 2 commits intoParadoxZero:masterfrom
Open
Added menu sound effects for select and click actions#20harsh-k7 wants to merge 2 commits intoParadoxZero:masterfrom
harsh-k7 wants to merge 2 commits intoParadoxZero:masterfrom
Conversation
ParadoxZero
requested changes
Jun 21, 2025
Owner
ParadoxZero
left a comment
ParadoxZero
left a comment
There was a problem hiding this comment.
Thank you so much for your PR!
I need a couple of changes before I can accept it -
- Please undo the auto formatted changes - use tab width as 2 for the project.
- Include the public headers which seem to be missing.
- Move the sample files to example - and update the example to set the sound config.
| std::cout << " Processing item " << menu_item.name << std::endl; | ||
| Menu(sf::RenderTarget &window, MenuConfig config) | ||
| : _window(window), _style(config.style), _title(config.title) { | ||
| _click_sound.setBuffer(config.click_sound_effect); |
Owner
There was a problem hiding this comment.
Did you miss including the public header in your commit?
| struct coordinates { | ||
| float x = 0; | ||
| float y = 0; | ||
| float x = 0; |
Owner
There was a problem hiding this comment.
Lot of formatting changes - please don't do the auto format over the doc - I have the tab width set as 2 instead of 4 which is probably the cause.
Owner
There was a problem hiding this comment.
Put this sample audio next to the examples - Also add a readme with attribution and source of these assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements sound effects for menu interactions. The following changes have been made:
Integrated click.wav and select.wav into MenuConfig.
Added _click_sound for selection changes using Up/Down keys.
Added _select_sound for confirming menu choices using Return key.
Updated game_menu_impl.h and game_menu_impl.cpp to handle sound playback.
Ensured smooth functionality for menu navigation.
This enhancement aligns with issue #3 (Menu Sounds). Let me know if any adjustments are needed!