Fix mutable default argument bug in service retrieve methods

parcllabs/schemas/schemas.py

@@ -5,7 +5,7 @@
 from datetime import datetime
 from typing import Any
 
-from pydantic import BaseModel, Field, ValidationInfo, field_validator
+from pydantic import BaseModel, ConfigDict, Field, ValidationInfo, field_validator
 
 from parcllabs.enums import PropertyTypes, RequestLimits
 
@@ -318,12 +318,11 @@ def validate_record_updated_date_range(cls, v: str | None, info: ValidationInfo)
                     )
         return v
 
-    class Config:
-        """Pydantic configuration."""
-
-        extra = "forbid"  # Reject any extra fields
-        validate_assignment = True  # Validate on assignment
-        str_strip_whitespace = True  # Strip whitespace from strings
+    model_config = ConfigDict(
+        extra="forbid",
+        validate_assignment=True,
+        str_strip_whitespace=True,
+    )
 
 
 class PropertyV2RetrieveParamCategories(BaseModel):

parcllabs/services/metrics/portfolio_size_service.py

@@ -1,4 +1,3 @@
-from collections.abc import Mapping
 from typing import Any
 
 import pandas as pd
@@ -14,12 +13,14 @@ def retrieve(
         end_date: str | None = None,
         portfolio_size: str | None = None,
         limit: int | None = None,
-        params: Mapping[str, Any] | None = {},
+        params: dict[str, Any] | None = None,
         auto_paginate: bool = False,
     ) -> pd.DataFrame:
         """
         Retrieve portfolio size metrics for given parameters.
         """
+        if params is None:
+            params = {}
         if portfolio_size:
             params["portfolio_size"] = portfolio_size.upper()
 

parcllabs/services/metrics/property_type_service.py

@@ -1,4 +1,3 @@
-from collections.abc import Mapping
 from typing import Any
 
 import pandas as pd
@@ -14,12 +13,14 @@ def retrieve(
         end_date: str | None = None,
         property_type: str | None = None,
         limit: int | None = None,
-        params: Mapping[str, Any] | None = {},
+        params: dict[str, Any] | None = None,
         auto_paginate: bool = False,
     ) -> pd.DataFrame:
         """
         Retrieve property type metrics for given parameters.
         """
+        if params is None:
+            params = {}
         if property_type:
             params["property_type"] = property_type.upper()
 

parcllabs/services/properties/property_events_service.py

@@ -1,5 +1,4 @@
 from collections import deque
-from collections.abc import Mapping
 from concurrent.futures import ThreadPoolExecutor, as_completed
 from typing import Any
 
@@ -67,7 +66,7 @@ def retrieve(
         entity_owner_name: str | None = None,
         record_updated_date_start: str | None = None,
         record_updated_date_end: str | None = None,
-        params: Mapping[str, Any] | None = {},
+        params: dict[str, Any] | None = None,
     ) -> pd.DataFrame:
         """
         Retrieve property events for given parameters.