Skip to content

remove mutable param#99

Merged
zhibindai26 merged 1 commit intomainfrom
fix/mutable-params
Apr 14, 2026
Merged

remove mutable param#99
zhibindai26 merged 1 commit intomainfrom
fix/mutable-params

Conversation

@zhibindai26
Copy link
Copy Markdown
Contributor

  • Fix mutable default argument (params={}) in PortfolioSizeService.retrieve(), PropertyTypeService.retrieve(), and PropertyEventsService.retrieve()
  • The shared default dict caused portfolio_size and property_type values to silently leak into subsequent calls that omitted the params argument
  • Changed to idiomatic params=None with if params is None: params = {} guard in the function body
  • Changed from deprecated config to ConfigDict in pydantic model configs

@zhibindai26 zhibindai26 merged commit 6984dd5 into main Apr 14, 2026
1 check passed
@zhibindai26 zhibindai26 deleted the fix/mutable-params branch April 14, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants