Closed
Conversation
Adds support for a hidden CMD window so we can use it to replace the CMD window that flashes when we update the runtime files
Wires77
reviewed
Oct 25, 2025
Member
Wires77
left a comment
Wires77
left a comment
There was a problem hiding this comment.
Concerns about this:
- This introduces a hook in the Lua code that makes it very easy for a bad actor to distribute an unofficial PoB release and silently launch whatever malware they want. This was technically always the case with
os.executeand distributing unofficial code, but this makes it easier - If something goes wrong with the update process, like if a file to be updated is locked for some reason, there is no way to know what is going on. Previously we've seen bug reports where it hangs and we can tell them to close other PoB instances/other software, but this doesn't show that anymore. (I know we've added a workaround for the main cause of that issue, but still)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for a hidden CMD window so we can use it to replace the CMD window that flashes when we update the runtime files