Change Effective Max Hit to use the harmonic mean #9445
+7
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jayensee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Changes the Effective Max Hit to be the harmonic mean of the max hits instead of the second lowest max hit.
Additionally, it adds the Effective Max Hit to the detail stats, making them show up in the stats panel on the left, beneath the individual max hits, as well as in the tooltips that display the stat changes from taking passives, equipping items, etc
Description of the problem being solved:
The second lowest max hit is not a very intuitive definition for max hit because it ignores 4/5 of the max hits, including the lowest one (which is usually the most important one)
The harmonic mean allows all the max hits to affect the effective max hit while still behaving well with infinite max hit (chaos innoculation)
I think the an obvious example of the second lowest max hit being misleading is any CI build with around the same phys and ele max hits: if you take out CI and sort nodes by effective max hit, CI doesn't even show up because it doesn't really affect the second lowest max hit, despite the fact that the build is extremely squishy without CI.
Link to a build that showcases this PR:
https://pobb.in/ccUdP4u3vwZw
Before screenshot:
After screenshot: