Conversation
…components styles.
Member
|
@thet You raise some ideas and questions that are so big that I cannot possibly answer them here, nor can I oversee the consequences. Do you want to set up a workshop of an afternoon or perhaps longer to discuss? |
Member
Author
Member
|
The CSS bundle is work in progress. Whenever I have time I do a little bit. Recently I've made some improvements again and I hooked up another project to the centralised bundle to make it more robust. The fact that it's not ready is also the reason that I don't want to include CSS yet with the download on the patterns site. |
Member
Author
|
Hm... I think we need at least some CSS. |
Member
|
We haven’t had any CSS on the site so far but we are in dear need of the new site and the single universal bundle. Let’s not the basic needs because we also want something extra as a next step.
… Op 8 apr. 2021 om 20:57 heeft Johannes Raggam ***@***.***> het volgende geschreven:
Hm... I think we need at least some CSS.
But I can just JavaScript-import the CSS for external libraries like the date-picker, slick-slider, tooltips and so on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
920fba5 to
d57a28e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept and work in progress.
The idea is to allow individual components to be usable outside this repository and not need to build/import the whole CSS bundle.
I want to individually use the CSS here in individual patterns and only if they are loaded by importing these files in JavaScript. For example like in this commit: Patternslib/Patterns@2cde595
Note this is optional and these JavaScript imports can be easily turned off (as we will be the case for ploneintranet.prototype and others without any further changes in these integration packages).
For this to achieve I have to make some adaptions.
Due to a number of open and debatable questions it's probably faster to reach the goal of a downloadable Patternslib bundle if we just build the whole CSS and offer it for download. Which is probably huge, but we can improve later and eventually build on the ideas outlined above.
Some questions to @cornae:
Related: