web: handle nonexistent workflow folder paths in 08-finished.php#3852
Open
omkarrr2533 wants to merge 2 commits intoPecanProject:developfrom
Open
web: handle nonexistent workflow folder paths in 08-finished.php#3852omkarrr2533 wants to merge 2 commits intoPecanProject:developfrom
omkarrr2533 wants to merge 2 commits intoPecanProject:developfrom
Conversation
When a workflow's folder does not exist on the local machine (e.g. it was run on a different host), show the user what is known from the database (workflow ID, dates, hostname, notes) and explain that full results may be available on the original machine. Previously, missing folders were silently treated as still-running workflows, which was confusing and incorrect. Fixes PecanProject#3501
omkarrr2533
force-pushed
the
GH-3501-handle-nonexistent-workflow-paths
branch
from
09919a1 to
700434a
Compare
Contributor
Author
|
Hi @robkooper, whenever you get a chance could you take a look at this? Thanks! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When opening a workflow from BETYdb whose output folder doesn't exist on the current machine, the page shows "Still running" which is confusing. This happens because 08-finished.php reads files from $workflow['folder'] without checking if the path exists first.
This PR adds an is_dir() check before any file reads. When the folder is missing, it shows a table with whatever info the database has (workflow ID, dates, hostname, notes) instead of the misleading status.
Also removed a duplicate
Execution Status
tag.Closes #3501
Type of Change
Bug fix