Skip to content

Integrate LPJ-GUESS with SDA module and synchronize with latest upstream#3914

Open
yinghaoSunn wants to merge 6 commits intoPecanProject:developfrom
yinghaoSunn:develop
Open

Integrate LPJ-GUESS with SDA module and synchronize with latest upstream#3914
yinghaoSunn wants to merge 6 commits intoPecanProject:developfrom
yinghaoSunn:develop

Conversation

@yinghaoSunn
Copy link
Copy Markdown
Contributor

@yinghaoSunn yinghaoSunn commented Apr 2, 2026

Description

This PR implements the coupling of LPJ-GUESS within the PEcAn Sequential Data Assimilation (SDA) workflow. It includes critical updates to state handling, binary data extraction, and ensures full compatibility with the latest PEcAn develop branch:

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge branch 'my-work-backup-20260331' into develop

# Conflicts:
#	modules/assim.sequential/R/Adjustment.R
#	modules/assim.sequential/R/Analysis_sda_block.R
#	modules/assim.sequential/R/sda.enkf_MultiSite.R
#	modules/uncertainty/R/ensemble.R
#	modules/uncertainty/R/get.parameter.samples.R
@github-actions github-actions bot added the models label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant