PeerDB UI: Rename hard delete, hide soft delete for CH mirrors#4043
Merged
Amogh-Bharadwaj merged 3 commits intomainfrom Mar 30, 2026
Merged
PeerDB UI: Rename hard delete, hide soft delete for CH mirrors#4043Amogh-Bharadwaj merged 3 commits intomainfrom
Amogh-Bharadwaj merged 3 commits intomainfrom
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
iamKunalGupta
approved these changes
Mar 11, 2026
d157794 to
65c4fb9
Compare
Contributor
🔄 Flaky Test DetectedAnalysis: Docker Hub returned a 500 Internal Server Error when pulling mysql:5.7, causing an infrastructure setup failure unrelated to any code change. ✅ Automatically retrying the workflow |
Contributor
🔄 Flaky Test DetectedAnalysis: TestMySQLSSHResetPeer is a timing-sensitive test that injects a network reset via toxiproxy and expects the query to fail quickly, but it non-deterministically times out instead — a race between connection teardown propagation and the query deadline. ✅ Automatically retrying the workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is some confusion in the user community around these two toggles and their behaviour for CH mirrors.
The
_peerdb_is_deletedcolumn is currently mandatory for ClickHouse. Therefore the soft delete switch is irrelevant as well as the "Disable all PeerDB Columns" switch.Hard delete is a misleading setting name, changes it to be more specific