Skip to content

PeerDB UI: Rename hard delete, hide soft delete for CH mirrors#4043

Merged
Amogh-Bharadwaj merged 3 commits intomainfrom
rename-hard-delete
Mar 30, 2026
Merged

PeerDB UI: Rename hard delete, hide soft delete for CH mirrors#4043
Amogh-Bharadwaj merged 3 commits intomainfrom
rename-hard-delete

Conversation

@Amogh-Bharadwaj
Copy link
Copy Markdown
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Mar 11, 2026

Currently there is some confusion in the user community around these two toggles and their behaviour for CH mirrors.
The _peerdb_is_deleted column is currently mandatory for ClickHouse. Therefore the soft delete switch is irrelevant as well as the "Disable all PeerDB Columns" switch.
Hard delete is a misleading setting name, changes it to be more specific

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2162 1 2161 162
View the top 1 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/connectors/mysql::TestMySQLSSHResetPeer
Stack Traces | 17s run time
=== RUN   TestMySQLSSHResetPeer
2026/03/30 13:44:46 INFO Setting up SSH connection x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} Server=localhost:42003
    ssh_keepalive_test.go:83: Adding reset_peer toxic - should cause immediate connection failure
2026/03/30 13:45:01 ERROR Keepalive request failed, marking tunnel as bad x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} error=EOF
2026/03/30 13:45:01 INFO SSH keepalive failed, closing connection x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
    ssh_keepalive_test.go:83: Query should have failed quickly due to connection reset, not timeout
2026/03/30 13:45:03 INFO Closing MySQL connector x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/03/30 13:45:03 ERROR [mysql] failed to close SSH tunnel x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} error="close tcp [::1]:46624->[::1]:42003: use of closed network connection"
--- FAIL: TestMySQLSSHResetPeer (17.03s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Amogh-Bharadwaj Amogh-Bharadwaj enabled auto-merge (squash) March 30, 2026 13:40
@github-actions
Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: Docker Hub returned a 500 Internal Server Error when pulling mysql:5.7, causing an infrastructure setup failure unrelated to any code change.
Confidence: 0.97

✅ Automatically retrying the workflow

View workflow run

@github-actions
Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: TestMySQLSSHResetPeer is a timing-sensitive test that injects a network reset via toxiproxy and expects the query to fail quickly, but it non-deterministically times out instead — a race between connection teardown propagation and the query deadline.
Confidence: 0.88

✅ Automatically retrying the workflow

View workflow run

@Amogh-Bharadwaj Amogh-Bharadwaj merged commit 25433bd into main Mar 30, 2026
19 of 20 checks passed
@Amogh-Bharadwaj Amogh-Bharadwaj deleted the rename-hard-delete branch March 30, 2026 14:16
Amogh-Bharadwaj added a commit that referenced this pull request Apr 6, 2026
This PR makes two fixes:
1. Fix the stats which issue which
#4109 attempted to fix
2. Implements missed item in
#4043 where along with hiding
the `Disable all PeerDB columns` toggle, also had to change the default
for that to be true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants