Skip to content

Housekeeping on ProjectInterfaces.js#520

Open
LordCat0 wants to merge 8 commits intoPenguinMod:mainfrom
LordCat0:main
Open

Housekeeping on ProjectInterfaces.js#520
LordCat0 wants to merge 8 commits intoPenguinMod:mainfrom
LordCat0:main

Conversation

@LordCat0
Copy link
Contributor

Multiple people have pointed out how bad my coding was back then when I first made this.
I can obviously do better now.
This will format the extension better, and fix a few bugs and performance issues.

Changing the class name of the extensions shouldn't cause any issues because its not used outside of the extension itself.
Icons sourced from svgrepo.com
@LordCat0 LordCat0 marked this pull request as ready for review February 14, 2026 03:11
@JeremyGamer13 JeremyGamer13 added the extension update This updates an already existing extension label Feb 16, 2026
Copy link
Member

@JeremyGamer13 JeremyGamer13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant review the whole thing right now but i have 2 notes

defaultValue: "My element",
},
dir: {
type: Scratch.ArgumentType.NUMBER,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should use the ANGLE picker?

x: metadata[elementid].x,
y: metadata[elementid].y,
});
}, 1); // Timeout needed because for some reason it wont run otherwise..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would prefer if this was done in a nicer way but if there is literally no solution other than this hack then i suppose its just gonna have to stay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension update This updates an already existing extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants