[Prototype] Lit testing for the Unified Compiler#2462
Draft
[Prototype] Lit testing for the Unified Compiler#2462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
We're considering using proper lit testing for the unified compiler. This PR is a proof of concept for what such tests may look like.
Description of the Change:
test_xdsl_combine_global_phases.pylit.cfg.pyto allow MLIR files to be usable as lit testsCATALYST_XDSL_UNIVERSE. The class expects the dialect and transform dictionaries to have functions that return the respective dialects/transforms as values rather than the dialects/transforms themselves.Benefits:
Some notes:
// -----separator between tests is necessary so that lit can split of the file into separate tests properly.RUNcomment at the top is used bylitto execute filecheckxdsl-optto apply the pass to the input file (specified with%s)FileCheck, which compares the output ofxdsl-optwith the input filePossible Drawbacks:
Related GitHub Issues:
[sc-109712]