Skip to content

Fix/manual null scenario #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AECohn wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Fix/manual null scenario #1403

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2cdb12
fix: calls scenario in SetRoomCombinationScenario preventing null fro…
AECohn Mar 20, 2026
e003e4d
fix: move ChangeScenario outside of loop, remove the discard modifier
AECohn Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/PepperDash.Essentials.Core/Room/Combining/EssentialsRoomCombiner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,10 @@ public void SetRoomCombinationScenario(string scenarioKey)
else
{
Debug.LogMessage(LogEventLevel.Debug, this, "Unable to find partition with key: '{0}'", partitionState.PartitionKey);
}
}
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be trailing whitespace after the closing brace on this line. Please remove the extra spaces to avoid noisy diffs and keep formatting consistent.

Suggested change
}
}

Copilot uses AI. Check for mistakes.
}
// Activates the scenario to prevent _currentScenario from being null when starting in manual mode.
ChangeScenario(scenario);
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangeScenario returns Task (async) and is being invoked without awaiting or otherwise observing the task. This can hide exceptions from Activate/Deactivate and can also allow overlapping scenario changes if this method is called multiple times quickly. Consider explicitly firing-and-forgetting with exception logging (e.g., capturing the returned task and handling faults) or introducing a serialized/queued scenario-change mechanism so only one activation runs at a time.

Suggested change
ChangeScenario(scenario);
var _ = ChangeScenario(scenario).ContinueWith(t =>
{
var ex = t.Exception != null ? t.Exception.Flatten() : null;
if (ex != null)
{
Debug.LogMessage(LogEventLevel.Error, this,
"Error changing scenario to '{0}': {1}", scenario.Key, ex);
}
}, TaskContinuationOptions.OnlyOnFaulted);

Copilot uses AI. Check for mistakes.
}
else
{
Expand Down
Loading