Fix warning when using key parameter of kmip_bio_register_symmetric_key#1
Open
ldonoso wants to merge 1 commit intoPercona-Lab:masterfrom
Open
Fix warning when using key parameter of kmip_bio_register_symmetric_key#1ldonoso wants to merge 1 commit intoPercona-Lab:masterfrom
ldonoso wants to merge 1 commit intoPercona-Lab:masterfrom
Conversation
*Problem*:
clang 10 shows the following warning:
```
/libkmip/libkmip/src/kmip_bio.c:313:14:
warning: assigning to 'uint8 *' (aka 'unsigned char *') from 'char *'
converts between pointers to integer types with different sign
[-Wpointer-sign]
bs.value = key;
^ ~~~
```
*Solution:*
Change the type of the parameter so it matches the requested type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
clang 10 shows the following warning:
Solution:
Change the type of the parameter so it matches the requested type.