Fix warning shadowing result variable in the #define CHECK_ENUM#22
Open
ivan-v-kush wants to merge 1 commit intoPercona-Lab:masterfrom
Open
Fix warning shadowing result variable in the #define CHECK_ENUM#22ivan-v-kush wants to merge 1 commit intoPercona-Lab:masterfrom
ivan-v-kush wants to merge 1 commit intoPercona-Lab:masterfrom
Conversation
```
In file included from src/libkmip/libkmip/src/kmip.c:15: src/libkmip/libkmip/src/kmip.c: In function ‘kmip_decode_name’: ../../contrib/pg_tde/src/libkmip/libkmip/include/kmip.h:1414:9: warning: declaration of ‘result’ shadows a previous local [-Wshadow=compatible-local]
int result = kmip_check_enum_value((A)->version, (B), (C)); \
^~~~~~
src/libkmip/libkmip/src/kmip.c:12759:5: note: in expansion of macro ‘CHECK_ENUM’
CHECK_ENUM(ctx, KMIP_TAG_NAME_TYPE, value->type);
^~~~~~~~~~
src/libkmip/libkmip/src/kmip.c:12742:9: note: shadowed declaration is here
int result = 0;
^~~~~~
```
Contributor
|
LGTM |
lukin-oleksiy
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, in the macros
CHECK_ENUMwe need to removeint, i.e. not create aresultvar. Or change a name to another.I think, renaming is more safe