Make function signature of cthreads_error_string() dependent on if the compiler supports it for better warnings.#6
Open
0xfadead wants to merge 9 commits intoPerformanC:mainfrom
Open
Make function signature of cthreads_error_string() dependent on if the compiler supports it for better warnings.#60xfadead wants to merge 9 commits intoPerformanC:mainfrom
cthreads_error_string() dependent on if the compiler supports it for better warnings.#60xfadead wants to merge 9 commits intoPerformanC:mainfrom
Conversation
…er supports it Making something a static array gives compiler warnings when the length of the array is smaller than the provided length.
ThePedroo
requested changes
Jan 21, 2025
Member
ThePedroo
left a comment
ThePedroo
left a comment
There was a problem hiding this comment.
Looks good code-wise, but there are some syntax changes that must be done and also suggestions.
ThePedroo
added
enhancement
Member
|
(Who is RandomEden too?) |
Co-authored-by: Pedro.js <pedroolimpioguerra@gmail.com> Signed-off-by: Awildidiot <69577313+0xfadead@users.noreply.github.com>
Contributor
Author
|
Why is my laptop recognised as "RandomEden" 🤣 |
Co-authored-by: Pedro.js <pedroolimpioguerra@gmail.com> Signed-off-by: Awildidiot <69577313+0xfadead@users.noreply.github.com>
Co-authored-by: Pedro.js <pedroolimpioguerra@gmail.com> Signed-off-by: Awildidiot <69577313+0xfadead@users.noreply.github.com>
Co-authored-by: Pedro.js <pedroolimpioguerra@gmail.com> Signed-off-by: Awildidiot <69577313+0xfadead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
bufparameter is now a static VLA, if the compiler supports it, this gives better warnings if the function is used improperly (passing NULL or an array that is too short.)Why
This improves warnings and therefore experience with CThreads.
Checkmarks
Additional information
THIS CHANGES THE SIGNATURE OF THIS FUNCTION!