Skip to content

Restore pre-Path::Tiny HasLocation upward traversal semantics #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xsawyerx wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Restore pre-Path::Tiny HasLocation upward traversal semantics #1782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/Dancer2/Core/Role/HasLocation.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,11 @@ sub _build_location {
last;
}

$subdir = $subdir->parent;
# Preserve pre-Path::Tiny traversal behavior: keep walking "up"
# even when current subdir is ".".
$subdir = Path::Tiny::path( $subdir, '..' );

last if $subdir->realpath->stringify eq Path::Tiny->rootdir->stringify;
last if $subdir->absolute->stringify eq Path::Tiny->rootdir->stringify;
}

my $path = $subdir_found ? $subdir : $location;
Expand Down
Loading