fix: remove empty message sent on unavailable block#68
Merged
uink45 merged 1 commit intoPier-Two:mainfrom Mar 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@uink45
In reqresp_service.c on line 2279 you are sending an empty response when you don't have the requested block. According to the spec you should be sending nothing that and just close the stream. This is the cause of some of the ssz decoding failed logs on ream when trying to fetch blocks lantern doesn't have. We are flooded by the logs below as this is unexpected. I will add a check for this in Ream as well but I think it is worthwhile to not send the empty message to comply with spec.
Relevant portion of spec: https://github.com/leanEthereum/leanSpec/blob/main/src/lean_spec/subspecs/networking/reqresp/handler.py#L174-L222
Feel free to merge, request changes or close this PR.