[Communication] PR8: Modify Simulation and SimManager

[Joseph0120]

Files Added:
4_swarms_1_ucav.pbtxt

Files Modified:
SimManager.cs

Description:
In SimManager, now it makes sure that it clears pending message in mailbox every time.
Created new simple simulation case 4_swarms_1_ucav.pbtxt and set it to default.

[coderabbitai]

Warning

Rate limit exceeded

@Joseph0120 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 22 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 24 minutes and 22 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a1206bfc-5482-4279-b4b5-31addaf30983

📥 Commits

Reviewing files that changed from the base of the PR and between 24b5957 and dbe07cf.

📒 Files selected for processing (2)

• Assets/Scripts/Managers/SimManager.cs
• Assets/StreamingAssets/Configs/Simulations/4_swarms_1_ucav.pbtxt

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch joseph/communication_delay_PR8

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[stacklane-pr-stack-visualizer]

🧱 Stack PR · Part of stack (9 PRs total)

Stack Structure:

• [Communication] PR1: Added Base Files for Mailbox #212 joseph/communication_delay_PR1
  • [Communication] PR2: Set up IADS proxy for Mailbox use #213 joseph/communication_delay_PR2
    • [Communication] PR3: Added Central Mailbox Component. #214 joseph/communication_delay_PR3
      • [Communication] PR4: IAgent and AgentBase Supports Mailbox Delivery #215 joseph/communication_delay_PR4
        • [Communication] PR5: IADS.cs now supports Mailbox #217 joseph/communication_delay_PR5
          • [Communication] PR6: InterceptorBase.cs now supports mailbox. #218 joseph/communication_delay_PR6
            • [Communication] PR7: CarrierBase.cs now supports mailbox #219 joseph/communication_delay_PR7
              • [Communication] PR8: Modify Simulation and SimManager #220 joseph/communication_delay_PR8 ← YOU ARE HERE
                • [Communication] PR9: Added Mailbox tests #221 joseph/communication_delay_PR9

[gemini-code-assist]

Code Review

This pull request updates the default simulation configuration to a new swarm-based scenario and implements a mailbox cleanup process in the EndSimulation method. Feedback indicates that clearing the mailbox only at the end of a simulation may be insufficient due to Unity's delayed destruction phase and manual resets, which could allow "zombie" messages to persist into subsequent runs. It is suggested to also clear the mailbox at the start of the simulation to guarantee a clean state.

[gemini-code-assist]

Clearing the mailbox in EndSimulation is a good step towards ensuring a clean state between runs. However, there are two scenarios where this might be insufficient:

1. Manual Resets: If ResetAndStartSimulation is called directly (e.g., from a UI button or external script), EndSimulation is bypassed, and the mailbox won't be cleared.
2. Destruction Phase Messages: Since Destroy() in Unity is delayed until the end of the frame, any messages sent by agents during their OnDestroy or OnDisable methods will be added to the mailbox after this clear call. These "zombie" messages will then persist into the next simulation run, which is particularly problematic for simulations involving communication delays.

Consider moving or also adding the ClearPendingMessages() call to the beginning of StartSimulation() to ensure the mailbox is always empty right before new agents are initialized. This would provide a more robust guarantee of a clean state.