Draft
Conversation
caspiano
added
type: enhancement
caspiano
force-pushed
the
feat/static-compilation
branch
2 times, most recently
from
d0307a0 to
e1adca3
Compare
caspiano
force-pushed
the
feat/static-compilation
branch
from
e1adca3 to
1851ab6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned by straight-shoota here, only musl builds are supported for static compilation.
We'll need to update the asdf-crystal plugin to support crystal binaries built against musl, so we are brutally blocked by crystal-lang/crystal/issues/8732
From this point on though, it's unlikely artefacts will be available for drivers on crystal < 1.1.0.
This, in combination with the legacy driver compilation pathway (can be solved in the meantime), means we should try to migrate everyone to latest drivers where possible.
I don't think we'll be backwards compatible after the static builds themselves are supported.