[codex] Fix GX eik input handling and subprocess errors#2143
Draft
rmchurch wants to merge 1 commit intoPlasmaControl:yge/gxfrom
Draft
[codex] Fix GX eik input handling and subprocess errors#2143rmchurch wants to merge 1 commit intoPlasmaControl:yge/gxfrom
rmchurch wants to merge 1 commit intoPlasmaControl:yge/gxfrom
Conversation
YigitElma
reviewed
Mar 31, 2026
Collaborator
YigitElma
left a comment
There was a problem hiding this comment.
Thanks for this @rmchurch! I was naively expecting the user to put eik, but I guess people use the same template file for multiple cases.
If this is ready, I can approve/merge it to yge/gx, and create a GX wrapper PR later. Does this sound good to you?
Collaborator
There was a problem hiding this comment.
We actually don't require writing tests for the desc.external module. But these look good to me. We can decide to keep them or not in the actual PR for the yge/gx branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
geo_option = "eik"so DESC's plain-text geometry files match the GX input modestdout.gx/stderr.gxcontextWhy
The GX wrapper was generating a plain-text geometry file while allowing templates to keep
geo_option = "nc". That made GX fail with an opaque nonzero exit, and the callback path surfaced it as a raw subprocess failure instead of a useful GX-specific error.Impact
This makes the GX integration robust against NC-based templates and preserves actionable failure context when GX exits nonzero.
Validation
/global/cfs/projectdirs/m4505/rchurchi/conda-envs/desc-gx/bin/python -m pytest tests/test_external_gx.py -q