Fix example script using literal placeholder instead of real client ID#2
Open
fiveinchpixie wants to merge 1 commit intoPlexTrac-Labs:mainfrom
Open
Conversation
- Replace hardcoded '<id_of_client>' with logic to read from config or list clients and use the first accessible one - Add optional client_id to config.yaml template - Document client_id in README - Fix PTWrapperLibraryResponse usage: use status_code and .json attribute instead of .ok and .json() method Made-with: Cursor
Author
|
I was having some issues with the auth, so I decided to share the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix example script using literal placeholder instead of real client ID
The example in
main.pywas using the literal string"<id_of_client>"as the client ID, causing 403 Forbidden errors ("User does not have access to client NaN").Changes:
client_idfrom config or list clients and use the first accessible oneclient_idto config.yaml templateclient_idin READMEPTWrapperLibraryResponseusage: usestatus_codeand.jsonattribute instead of.okand.json()method