Fix gametype filter UI bugs and code quality issues#10
Open
bretonium wants to merge 1 commit intoPointer31:infclass-based-19.5-2from
Open
Fix gametype filter UI bugs and code quality issues#10bretonium wants to merge 1 commit intoPointer31:infclass-based-19.5-2from
bretonium wants to merge 1 commit intoPointer31:infclass-based-19.5-2from
Conversation
- Fix HSplitBottom → HSplitTop so gametype filter header is actually visible - Simplify token parsing: drop pGametypeNext, use local pToken per iteration - Replace magic number 9 with MAX_GAMETYPE_FILTERS constant - Size s_Buttons[MAX_GAMETYPE_FILTERS + 1] (was [11] with unexplained +1) - Move "No filter" button to s_Buttons[MAX_GAMETYPE_FILTERS] (index 9) - Rename isSelected → IsSelected to match project convention - Switch Config()->m_Cl* to g_Config.m_Cl* for consistency with surrounding code - Add bounds check via minimum() in str_copy for token length - Document cl_position_community_filter values 0/1/2 in config description - Remove attribution comment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
f072e00 to
ce4d44d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist