Conversation
data/v2/csv/location_areas.csv
Outdated
| 749,657,0,unknown-area-324 | ||
| 750,657,0,unknown-area-326 | ||
| 751,657,0,unknown-area-327 | ||
| 751,657,0,outside |
There was a problem hiding this comment.
outside seems a too broad term, isn't it?
There was a problem hiding this comment.
The area is called "Outside" on Bulbapedia. I checked the encounters already mapped before any of my horde encounter additions to make sure I had it correct.
https://bulbapedia.bulbagarden.net/wiki/Victory_Road_(Kalos)
|
@ItsMeJoji we recently modified many files that your PR touches as well. Could you resolve all the conflicts? |
|
Ah, sorry about that. It merged without conflict, but looking at the merge, it seems that it just reverted the recent changes made to master. |
|
hi! When you first proposed your changes it was mergeable but now that the |
4c08b6f to
46295d6
Compare
Adding missing Horde Encounter information for XY and ORAS. The information was copied from Bulbapedia's page about the mechanic. Also noticed some minor differences (level max for lombre, and an area labeled "unknown" that can be set as "outside")
Some considerations for the future are the differences in encounter between RSE and ORAS are not correctly documented (see Shoal Cave), and some Horde Encounters having a 4-1 split in certain encounters (not sure how to accomplish this with current data structure).