add TypeScript types to annotation async fetchers#414
Open
Conversation
- Rename api/typeahead.js → .ts with typed generic factory - Define TypeaheadLocationSuggestion and TypeaheadAgencySuggestion types - Type useMutation generics, refs, emits, and handlers in SearchLocationForm and SearchAgencyForm - Re-export LocationSuggestion from canonical typeahead types - Remove broken UseQueryResult annotation from index.vue - Remove dead AgencyLocationSuggestionType import from helpers.ts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joshuagraber
approved these changes
Apr 9, 2026
Collaborator
joshuagraber
left a comment
joshuagraber
left a comment
There was a problem hiding this comment.
Looks good to me. One question on the devcontainer setup. I'm not opposed to adding that, but let's document any changes to dev workflow, please.
Collaborator
There was a problem hiding this comment.
Did you mean to commit this?
maxachis
force-pushed
the
issue/404-annotation-api-types
branch
from
104940d to
d9b548f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeaheadAgencySuggestion types and a generically-typed factory function
SearchLocationForm.vue and SearchAgencyForm.vue
compatibility
(TanStack Query v5 infers it)
Closes #404
Test plan
data-sources/create.vue) still resolve the renamed import