Nova Scotia Age Amount Supplement#458
Open
okeyiii wants to merge 12 commits intoPolicyEngine:masterfrom
Open
Conversation
Add new files Fixes PolicyEngine#455
…-canada into okeyiii/issue455
Create pr and new files Fix #issue455
Fix the test fail
policyengine_canada/parameters/gov/provinces/ns/tax/income/credits/age/age_supplement/base.yaml
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/ns/tax/income/credits/age/age_supplement/base.yaml
Outdated
Show resolved
Hide resolved
change name Fixes PolicyEngine#455
fix name
YiweiJ
reviewed
Nov 21, 2023
policyengine_canada/parameters/gov/provinces/ns/tax/income/credits/age/supplement/base.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Dec 3, 2023
policyengine_canada/parameters/gov/provinces/ns/tax/income/credits/age/age_supplement/base.yaml
Outdated
Show resolved
Hide resolved
...canada/parameters/gov/provinces/ns/tax/income/credits/age/age_supplement/phase_out_rate.yaml
Outdated
Show resolved
Hide resolved
...yengine_canada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.py
Show resolved
Hide resolved
...yengine_canada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.py
Outdated
Show resolved
Hide resolved
...yengine_canada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.py
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Dec 10, 2023
...anada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement_eligible.py
Outdated
Show resolved
Hide resolved
...anada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement_eligible.py
Outdated
Show resolved
Hide resolved
...anada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement_eligible.py
Outdated
Show resolved
Hide resolved
...yengine_canada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.py
Outdated
Show resolved
Hide resolved
policyengine_canada/tests/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.yaml
Show resolved
Hide resolved
policyengine_canada/tests/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.yaml
Outdated
Show resolved
Hide resolved
...anada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement_eligible.py
Show resolved
Hide resolved
policyengine_canada/tests/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.yaml
Outdated
Show resolved
Hide resolved
Fix PolicyEngine#455 Add a new check for age eligibility
PavelMakarchuk
requested changes
Jan 17, 2024
policyengine_canada/parameters/gov/provinces/ns/tax/income/credits/age/supplement/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/ns/tax/income/credits/age/supplement/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/ns/tax/income/credits/age/supplement/base.yaml
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/ns/tax/income/credits/age/supplement/base.yaml
Outdated
Show resolved
Hide resolved
...anada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement_eligible.py
Show resolved
Hide resolved
Add unit test for age amount supplement
Add unit test for age amount supplement
PavelMakarchuk
approved these changes
Jan 25, 2024
MaxGhenis
requested changes
Jan 26, 2024
Contributor
MaxGhenis
left a comment
MaxGhenis
left a comment
There was a problem hiding this comment.
The law ties eligibility to the general age amount credit eligibility. So please refactor that credit's code to separate an eligibility variable depending only on age, and use that for both credits.
The ns_age_tax_credit variable also looks not to represent the phase-out of that credit correctly. Please fix that variable according to the law and form in this PR.
..._canada/tests/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement_eligible.yaml
Outdated
Show resolved
Hide resolved
...ine_canada/parameters/gov/provinces/ns/tax/income/credits/age/supplement/phase_out_rate.yaml
Show resolved
Hide resolved
...yengine_canada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.py
Outdated
Show resolved
Hide resolved
...yengine_canada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.py
Outdated
Show resolved
Hide resolved
change file name and add age eligibility to be depencies as all files
PavelMakarchuk
requested changes
Feb 2, 2024
...anada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement_eligible.py
Show resolved
Hide resolved
Collaborator
There was a problem hiding this comment.
cerate a variable
ns_age_amount.py
ns_age_amount_eligible.py
...yengine_canada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.py
Outdated
Show resolved
Hide resolved
...anada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement_eligible.py
Outdated
Show resolved
Hide resolved
...anada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement_eligible.py
Outdated
Show resolved
Hide resolved
| label = "Nova Scotia Age tax credit" | ||
| definition_period = YEAR | ||
| defined_for = ProvinceCode.NS | ||
| defined_for = "ns_age_amount_supplement_eligible" |
Collaborator
There was a problem hiding this comment.
delete this as this is for the age tax credit
Collaborator
There was a problem hiding this comment.
please double check the logic of the credit making sure it is accurate
...yengine_canada/variables/gov/provinces/ns/tax/income/credits/age/ns_age_amount_supplement.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455