Fix VA spouse tax adjustment using incorrectly prorated VAGI#7480
Open
PavelMakarchuk wants to merge 4 commits intomainfrom
Open
Fix VA spouse tax adjustment using incorrectly prorated VAGI#7480PavelMakarchuk wants to merge 4 commits intomainfrom
PavelMakarchuk wants to merge 4 commits intomainfrom
Conversation
The va_agi_person formula prorated combined VA AGI by each person's federal AGI share, which incorrectly spread person-specific subtractions (especially the $12K age deduction) across both spouses. This made elderly spouses with income below the age deduction appear to have positive VAGI, incorrectly qualifying the couple for the spouse tax adjustment. Now applies the age deduction directly to each eligible person and only prorates non-age subtractions by federal AGI share. Closes #6958 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests the full computation chain from employment_income through va_income_tax, matching TaxAct output exactly ($1,402.22). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7480 +/- ##
============================================
+ Coverage 70.60% 100.00% +29.39%
============================================
Files 3896 2 -3894
Lines 56278 38 -56240
Branches 277 0 -277
============================================
- Hits 39735 38 -39697
+ Misses 16542 0 -16542
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
va_agi_personto apply the age deduction directly to eligible persons instead of prorating it across both spouses by federal AGI shareva_age_deduction_personvariable to allocate the TaxUnit-level age deduction to each eligible personCloses #6958
Test plan
va_agi_persontests pass (2 updated + 1 new)va_spouse_tax_adjustment_eligibletests pass (6 existing + 1 new integration test from issue)🤖 Generated with Claude Code