implement config override on load#2477
Merged
ljeub-pometry merged 4 commits intodb_v4from Feb 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: a3a1697 | Previous: b4ca25f | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
396 ns/iter (± 1) |
1 ns/iter (± 0) |
396 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
9392151 ns/iter (± 97140) |
1502292 ns/iter (± 5117) |
6.25 |
lotr_graph_window_100/num_edges |
28 ns/iter (± 0) |
9 ns/iter (± 0) |
3.11 |
lotr_graph_window_100/num_nodes |
419 ns/iter (± 10) |
5 ns/iter (± 0) |
83.80 |
lotr_graph_window_100_materialise/materialize |
9651725 ns/iter (± 62255) |
1676712 ns/iter (± 4546) |
5.76 |
lotr_graph_window_10/has_node_existing |
129 ns/iter (± 7) |
61 ns/iter (± 10) |
2.11 |
lotr_graph_window_10/iterate nodes |
35217 ns/iter (± 226) |
10131 ns/iter (± 24) |
3.48 |
lotr_graph_window_10/iterate edges |
104548 ns/iter (± 337) |
44710 ns/iter (± 254) |
2.34 |
lotr_graph_window_10_materialise/materialize |
6186986 ns/iter (± 89992) |
1018583 ns/iter (± 5491) |
6.07 |
lotr_graph_subgraph_10pc/has_edge_existing |
521 ns/iter (± 4) |
88 ns/iter (± 1) |
5.92 |
lotr_graph_subgraph_10pc/num_nodes |
309 ns/iter (± 0) |
4 ns/iter (± 0) |
77.25 |
lotr_graph_subgraph_10pc/has_node_existing |
244 ns/iter (± 2) |
34 ns/iter (± 0) |
7.18 |
lotr_graph_subgraph_10pc/iterate nodes |
4608 ns/iter (± 16) |
830 ns/iter (± 1) |
5.55 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
129 ns/iter (± 10) |
60 ns/iter (± 14) |
2.15 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
4392 ns/iter (± 205) |
1364 ns/iter (± 3) |
3.22 |
lotr_graph_window_50_layered/num_edges |
79299 ns/iter (± 3504) |
39375 ns/iter (± 959) |
2.01 |
lotr_graph_window_50_layered/num_nodes |
105657 ns/iter (± 14349) |
22315 ns/iter (± 2848) |
4.73 |
lotr_graph_window_50_layered/has_node_existing |
1403 ns/iter (± 192) |
133 ns/iter (± 14) |
10.55 |
lotr_graph_window_50_layered/max_id |
119022 ns/iter (± 4009) |
27916 ns/iter (± 798) |
4.26 |
lotr_graph_window_50_layered/max_degree |
1983991 ns/iter (± 18598) |
293790 ns/iter (± 11518) |
6.75 |
lotr_graph_window_50_layered/iterate nodes |
240851 ns/iter (± 2065) |
16652 ns/iter (± 132) |
14.46 |
lotr_graph_window_50_layered/iterate edges |
210499 ns/iter (± 825) |
83313 ns/iter (± 309) |
2.53 |
lotr_graph_window_50_layered/max_neighbour_degree |
3632180 ns/iter (± 21665) |
400729 ns/iter (± 996) |
9.06 |
lotr_graph_window_50_layered/graph_latest |
186680 ns/iter (± 14068) |
37335 ns/iter (± 1538) |
5.00 |
lotr_graph_window_50_layered_materialise/materialize |
20119637 ns/iter (± 355849) |
3420109 ns/iter (± 20614) |
5.88 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
590214 ns/iter (± 3172) |
203169 ns/iter (± 2099) |
2.91 |
lotr_graph_persistent_window_50_layered/num_nodes |
140513 ns/iter (± 1727) |
32915 ns/iter (± 772) |
4.27 |
lotr_graph_persistent_window_50_layered/has_node_existing |
1831 ns/iter (± 467) |
174 ns/iter (± 85) |
10.52 |
lotr_graph_persistent_window_50_layered/max_id |
155424 ns/iter (± 2855) |
40474 ns/iter (± 1568) |
3.84 |
lotr_graph_persistent_window_50_layered/max_degree |
2757254 ns/iter (± 16946) |
457295 ns/iter (± 7503) |
6.03 |
lotr_graph_persistent_window_50_layered/iterate nodes |
339409 ns/iter (± 1028) |
35373 ns/iter (± 119) |
9.60 |
lotr_graph_persistent_window_50_layered/max_neighbour_degree |
5090549 ns/iter (± 11864) |
508683 ns/iter (± 1415) |
10.01 |
lotr_graph_persistent_window_50_layered/graph_latest |
283761 ns/iter (± 11641) |
59291 ns/iter (± 2250) |
4.79 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
48896343 ns/iter (± 883031) |
5294480 ns/iter (± 182613) |
9.24 |
lotr_graph/proto_decode |
9647930 ns/iter (± 60306) |
1954083 ns/iter (± 33467) |
4.94 |
lotr_graph/proto_encode |
9225215 ns/iter (± 49332) |
1193694 ns/iter (± 43350) |
7.73 |
This comment was automatically generated by workflow using github-action-benchmark.
fabubaker
approved these changes
Feb 8, 2026
Contributor
fabubaker
left a comment
There was a problem hiding this comment.
LGTM besides some minor nits.
…th when creating a graph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?