Skip to content

fix: s3 port type mismatch, add string_or_number_to_string deserializer#42

Merged
RambokDev merged 1 commit intomainfrom
dev
Mar 16, 2026
Merged

fix: s3 port type mismatch, add string_or_number_to_string deserializer#42
RambokDev merged 1 commit intomainfrom
dev

Conversation

@RambokDev
Copy link
Contributor

@RambokDev RambokDev commented Mar 16, 2026

Summary by CodeRabbit

  • Chores

    • Updated Rust compiler toolchain to version 1.94.0 for latest improvements and stability enhancements.
    • Updated Docker configuration for improved service deployments.
  • Improvements

    • Enhanced S3 storage provider to accept port configuration in multiple formats for better compatibility.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2aa0c8e5-009f-48bb-9d97-75a6c35fa6e4

📥 Commits

Reviewing files that changed from the base of the PR and between 174ead7 and c46c301.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • docker-compose.yml
  • docker/Dockerfile
  • src/services/storage/providers/s3/models.rs
  • src/utils/deserializer.rs

📝 Walkthrough

Walkthrough

Updates Rust toolchain from version 1.92.0 to 1.94.0, modifies Docker configurations including cargo-target volume settings and container networking, and introduces a custom deserializer function to handle S3 provider port configuration accepting both string and numeric inputs.

Changes

Cohort / File(s) Summary
Docker Configuration
docker-compose.yml, docker/Dockerfile
Version bump from rust:1.92.0 to rust:1.94.0; commented out cargo-target volume lines; updated EDGE_KEY value; added localhost extra_hosts entry.
Deserialization Enhancement
src/utils/deserializer.rs, src/services/storage/providers/s3/models.rs
New public function string_or_number_to_string handles deserialization of values as optional strings from either string or numeric inputs; applied via serde attribute to S3ProviderConfig port field.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A toolchain hops to v1.94,
Where Docker's paths now commented are,
S3 ports now dance both string and number bright,
Deserializers work their serde magic right! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@RambokDev RambokDev merged commit e9147d6 into main Mar 16, 2026
1 of 2 checks passed
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utils/deserializer.rs 0.00% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant