Skip to content

fix: Remove snapshot APIs that deadlock libuv thread pool#1338

Open
charlesvien wants to merge 2 commits into03-26-detect_non-standard_default_branch_namesfrom
03-26-file-watcher-crashes
Open

fix: Remove snapshot APIs that deadlock libuv thread pool#1338
charlesvien wants to merge 2 commits into03-26-detect_non-standard_default_branch_namesfrom
03-26-file-watcher-crashes

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Mar 26, 2026

Problem

@parcel/watcher's getEventsSince() and writeSnapshot() block libuv worker
threads indefinitely via a native mutex deadlock in FSEventsBackend, saturating
the default 4-thread pool and preventing clean shutdown.

Changes

  1. Remove snapshot-based change detection (getEventsSince/writeSnapshot calls)
  2. Update @parcel/watcher to 2.5.6 for upstream bug fixes
  3. Remove terminal font family setting from general settings

How did you test this?

Manually

@charlesvien charlesvien changed the title Remove terminal font family setting fix: Remove snapshot APIs that deadlock libuv thread pool Mar 26, 2026
Copy link
Copy Markdown
Member Author

charlesvien commented Mar 26, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@charlesvien charlesvien marked this pull request as ready for review March 26, 2026 11:20
@charlesvien charlesvien force-pushed the 03-26-file-watcher-crashes branch from 7f8af48 to a539262 Compare March 28, 2026 12:37
@charlesvien charlesvien force-pushed the 03-26-detect_non-standard_default_branch_names branch from b99d30b to a01c096 Compare March 28, 2026 12:37
@charlesvien charlesvien force-pushed the 03-26-file-watcher-crashes branch from a539262 to b4abfe4 Compare March 28, 2026 18:32
@charlesvien charlesvien force-pushed the 03-26-detect_non-standard_default_branch_names branch from a01c096 to 32623d4 Compare March 28, 2026 18:32
@charlesvien charlesvien mentioned this pull request Mar 28, 2026
@charlesvien charlesvien force-pushed the 03-26-detect_non-standard_default_branch_names branch from 32623d4 to e9fe4ae Compare March 29, 2026 08:59
@charlesvien charlesvien force-pushed the 03-26-file-watcher-crashes branch from b4abfe4 to 8feb992 Compare March 29, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant