Skip to content

Use shallow equality in session selector hooks #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanlab merged 1 commit into from
Mar 30, 2026
Merged

Use shallow equality in session selector hooks #1358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/code/src/renderer/features/sessions/hooks/useSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
extractAvailableCommandsFromEvents,
extractUserPromptsFromEvents,
} from "@utils/session";
import { shallow } from "zustand/shallow";
import {
type Adapter,
type AgentSession,
Expand Down Expand Up @@ -39,7 +40,7 @@ export const useAvailableCommandsForTask = (
const session = s.sessions[taskRunId];
if (!session?.events) return [];
return extractAvailableCommandsFromEvents(session.events);
});
}, shallow);
};

export function getAvailableCommandsForTask(
Expand Down Expand Up @@ -73,7 +74,7 @@ export const usePendingPermissionsForTask = (
if (!taskRunId) return new Map();
const session = s.sessions[taskRunId];
return session?.pendingPermissions ?? new Map();
});
}, shallow);
};

export function getPendingPermissionsForTask(
Expand All @@ -96,7 +97,7 @@ export const useQueuedMessagesForTask = (
if (!taskRunId) return [];
const session = s.sessions[taskRunId];
return session?.messageQueue ?? [];
});
}, shallow);
};

export const useOptimisticItemsForTask = (
Expand All @@ -107,7 +108,7 @@ export const useOptimisticItemsForTask = (
const taskRunId = s.taskIdIndex[taskId];
if (!taskRunId) return [];
return s.sessions[taskRunId]?.optimisticItems ?? [];
});
}, shallow);
};

// --- Config Option Hooks ---
Expand Down
Loading