Skip to content

Comments

fix: use $ip not $ip_addess#356

Merged
marandaneto merged 1 commit intoPostHog:masterfrom
iloveitaly:django-fix
Feb 20, 2026
Merged

fix: use $ip not $ip_addess#356
marandaneto merged 1 commit intoPostHog:masterfrom
iloveitaly:django-fix

Conversation

@iloveitaly
Copy link
Contributor

from what I can tell, $ip is what is used on the web and is probably the correct field

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@rafaeelaudibert rafaeelaudibert requested a review from a team February 19, 2026 03:21
@rafaeelaudibert
Copy link
Member

We've updated our release process. We require sampo now. Please rebase on master and check README to understand what should be done.

from what I can tell, $ip is what is used on the web and is probably the correct field
@marandaneto
Copy link
Member

matches our posthog/taxonomy/taxonomy.py as well

@marandaneto marandaneto merged commit a8b5529 into PostHog:master Feb 20, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants