Skip to content

Comments

fix: Remove dependency on backoff#435

Open
edgarrmondragon wants to merge 1 commit intoPostHog:masterfrom
edgarrmondragon:no-backoff
Open

fix: Remove dependency on backoff#435
edgarrmondragon wants to merge 1 commit intoPostHog:masterfrom
edgarrmondragon:no-backoff

Conversation

@edgarrmondragon
Copy link

It doesn't seem to be used anywhere and it's unmaintained.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 18, 2026

Additional Comments (1)

integration_tests/django5/uv.lock
Stale integration test lock file

The integration_tests/django5/uv.lock still lists backoff as a dependency of the posthog editable package (lines 29-35, 253, 264). Since this lock references posthog via { editable = "../" }, it's now out of sync with the updated pyproject.toml. Consider regenerating this lock file as part of this PR to keep it consistent.

Prompt To Fix With AI
This is a comment left during a code review.
Path: integration_tests/django5/uv.lock
Line: 253

Comment:
**Stale integration test lock file**

The `integration_tests/django5/uv.lock` still lists `backoff` as a dependency of the `posthog` editable package (lines 29-35, 253, 264). Since this lock references `posthog` via `{ editable = "../" }`, it's now out of sync with the updated `pyproject.toml`. Consider regenerating this lock file as part of this PR to keep it consistent.

How can I resolve this? If you propose a fix, please make it concise.

@rafaeelaudibert
Copy link
Member

We've updated our release process. We require sampo now. Please rebase on master and check README to understand what should be done.

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
@edgarrmondragon
Copy link
Author

We've updated our release process. We require sampo now. Please rebase on master and check README to understand what should be done.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants