Conversation
Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com>
Thijss
reviewed
Feb 15, 2026
Member
vincentkoppen
left a comment
vincentkoppen
left a comment
There was a problem hiding this comment.
Nice!
Some remarks, but not blocking. Also willing to make the requested changes myself if that is easier.
Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com>
* feat: add grid repr method Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: add grid repr method Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: add test for repr Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: docstring Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: to_txt Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * chore: add comment to test Co-authored-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Signed-off-by: Jaap Schouten <58551444+jaapschoutenalliander@users.noreply.github.com> * feat: to_txt Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: graph repr Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> --------- Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> Signed-off-by: Jaap Schouten <58551444+jaapschoutenalliander@users.noreply.github.com> Co-authored-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
* re-arrange and add AsymPowerSensorArray Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> * remove unnecessary code in __init__ in _core module Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> --------- Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
* add components Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add measured_object to merging logic Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add fault Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add test modify Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * fix delete branch, add delete appliance Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add appliance array base type Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add new tests Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add topologically full grid Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * delete_node for fixture Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * revise test Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * revert deletion Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * delete init file merge commit 2 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * readd init file merge commit 3 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * impor tchange merge commit 4 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add graph asserts Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add graph asserts 2 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * make deleting appliances private Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * remove qmin max Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> --------- Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
* fix: allow parallel edges in Grid.from_txt Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> * also make order fixed for nodes Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> * review comments Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> --------- Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com>
vincentkoppen
force-pushed
the
docs/feeder-ids
branch
from
18fc943 to
46259c0
Compare
…into docs/feeder-ids
|
Thijss
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation on the feeder ids functionality