Add components: AsymLoad, AsymGen, Shunt, VoltageRegulator, Fault by nitbharambe · Pull Request #160 · PowerGridModel/power-grid-model-ds

nitbharambe · 2026-02-16T21:32:12Z

Also fixes #159

Changes proposed in this PR include:

Add new components
Fix delete functions
Fix _increment_grid_ids_by_offset.

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

nitbharambe · 2026-02-17T09:07:11Z

Adding / Updating components guide for future additions in components

Add in src\power_grid_model_ds\_core\model\dtypes\ and src\power_grid_model_ds\_core\model\arrays\ and src\power_grid_model_ds\_core\model\arrays.py
Check topology related changes in existing functions: in _helpers and _modify. Eg. append, _increment_grid_ids_by_offset and delete_* functions
Check corresponding tests

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

vincentkoppen

Had a quick look and looks good overal.
One remark on the delete_appliance at this moment in time already. Will give a more thorough review end of next week once we have determined the path forward with regarding the delete functions.

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

vincentkoppen

Looks good, we will add the generic delete in a seperate PR

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

sonarqubecloud · 2026-02-27T11:08:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

* add components Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add measured_object to merging logic Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add fault Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add test modify Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * fix delete branch, add delete appliance Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add appliance array base type Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add new tests Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add topologically full grid Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * delete_node for fixture Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * revise test Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * revert deletion Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * delete init file merge commit 2 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * readd init file merge commit 3 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * impor tchange merge commit 4 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add graph asserts Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add graph asserts 2 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * make deleting appliances private Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * remove qmin max Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> --------- Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>

* docs: setup feeder ids notebook Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * update notebook Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> * feat: add grid and graph repr method (#152) * feat: add grid repr method Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: add grid repr method Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: add test for repr Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: docstring Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: to_txt Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * chore: add comment to test Co-authored-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Signed-off-by: Jaap Schouten <58551444+jaapschoutenalliander@users.noreply.github.com> * feat: to_txt Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> * feat: graph repr Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> --------- Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> Signed-off-by: Jaap Schouten <58551444+jaapschoutenalliander@users.noreply.github.com> Co-authored-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> * Expose AsymPowerSensorArray (#158) * re-arrange and add AsymPowerSensorArray Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> * remove unnecessary code in __init__ in _core module Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> --------- Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> * Add components: AsymLoad, AsymGen, Shunt, VoltageRegulator, Fault (#160) * add components Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add measured_object to merging logic Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add fault Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add test modify Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * fix delete branch, add delete appliance Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add appliance array base type Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add new tests Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add topologically full grid Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * delete_node for fixture Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * revise test Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * revert deletion Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * delete init file merge commit 2 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * readd init file merge commit 3 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * impor tchange merge commit 4 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add graph asserts Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * add graph asserts 2 Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * make deleting appliances private Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> * remove qmin max Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> --------- Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> * fix: allow parallel edges in Grid.from_txt (#162) * fix: allow parallel edges in Grid.from_txt Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> * also make order fixed for nodes Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> * review comments Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> --------- Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> * linting Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> --------- Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com> Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com> Signed-off-by: Jaap Schouten <58551444+jaapschoutenalliander@users.noreply.github.com> Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> Co-authored-by: Vincent Koppen <vincent.koppen@alliander.com> Co-authored-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Co-authored-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> Co-authored-by: Vincent Koppen <53343926+vincentkoppen@users.noreply.github.com>

nitbharambe and others added 9 commits February 7, 2026 13:40

add components

bb98406

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

Merge branch 'main' into feature/add-vtg-reg-asym-loadgen-shunt

cd6efc5

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

add measured_object to merging logic

2216a0f

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

add fault

cb97b43

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

add test modify

d466078

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

fix delete branch, add delete appliance

e3abffe

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

Merge branch 'main' into feature/add-vtg-reg-asym-loadgen-shunt

2bac367

Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>

add appliance array base type

e27df11

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

add new tests

e01af02

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

nitbharambe added 8 commits February 17, 2026 13:49

add topologically full grid

b5ffe23

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

delete_node for fixture

bfb8f9a

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

revise test

6c073b8

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

revert deletion

4eb6fbe

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

Merge branch 'main' into feature/add-vtg-reg-asym-loadgen-shunt

14d84a8

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

delete init file merge commit 2

84d9018

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

readd init file merge commit 3

200ca88

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

impor tchange merge commit 4

a7d7594

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

nitbharambe marked this pull request as ready for review February 18, 2026 12:57

nitbharambe added 2 commits February 19, 2026 16:25

add graph asserts

112a6f7

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

add graph asserts 2

09c2d32

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

vincentkoppen reviewed Feb 20, 2026

View reviewed changes

Comment thread src/power_grid_model_ds/_core/model/grids/base.py Outdated

make deleting appliances private

6f703b1

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

vincentkoppen approved these changes Feb 27, 2026

View reviewed changes

remove qmin max

09f3cc5

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

nitbharambe merged commit e4897d6 into main Feb 27, 2026
15 checks passed

nitbharambe deleted the feature/add-vtg-reg-asym-loadgen-shunt branch February 27, 2026 11:34

mgovers mentioned this pull request Mar 11, 2026

Fix generator and shunt appliance classes #180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add components: AsymLoad, AsymGen, Shunt, VoltageRegulator, Fault#160

Add components: AsymLoad, AsymGen, Shunt, VoltageRegulator, Fault#160
nitbharambe merged 21 commits intomainfrom
feature/add-vtg-reg-asym-loadgen-shunt

nitbharambe commented Feb 16, 2026 •

edited

Loading

Uh oh!

nitbharambe commented Feb 17, 2026

Uh oh!

vincentkoppen left a comment

Uh oh!

Uh oh!

vincentkoppen left a comment

Uh oh!

sonarqubecloud Bot commented Feb 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nitbharambe commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this PR include:

Uh oh!

nitbharambe commented Feb 17, 2026

Uh oh!

vincentkoppen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vincentkoppen left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Feb 27, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nitbharambe commented Feb 16, 2026 •

edited

Loading