Open
Conversation
wuestholz
reviewed
Apr 14, 2022
wuestholz
reviewed
Apr 14, 2022
Collaborator
Author
|
I think we cannot get rid of this implementation entirely. I simplified code a bit but the main idea remains:
I added a detail of the alternative that they've suggested us to do for the comparison. For any benchmark that we need to have a custom seed we need to repeatedly do the following (libpng for example):
I believe we'd better go with our implementation for the custom seed. I think the above alternative is doable but not really convenient. What do you think? @wuestholz |
|
@jiradeto Thanks a lot! Maybe we should try the following:
The key issue seems to be that each benchmark has their own structure and seeds directory. Modifying it would require changes to the Dockerfile and/or the build script. The combined PR should include 4 commits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users to set custom seed corpus for the experiment. To use this option, one has to set
--custom-seed-corpus-dirto path that has input files for the running benchmarks.For example:
and
/local/my-custom-corporamust have the following content: