feat(Tengoku Fansub): add activity#10657
Conversation
Signed-off-by: fkarlsefnii <aqayefmirfariz@icloud.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: fkarlsefnii <aqayefmirfariz@icloud.com>
Signed-off-by: fkarlsefnii <aqayefmirfariz@icloud.com>
Signed-off-by: fkarlsefnii <aqayefmirfariz@icloud.com>
Signed-off-by: fkarlsefnii <aqayefmirfariz@icloud.com>
Signed-off-by: fkarlsefnii <aqayefmirfariz@icloud.com>
Signed-off-by: fkarlsefnii <aqayefmirfariz@icloud.com>
| @@ -0,0 +1,42 @@ | |||
| { | |||
| "$schema": "https://schemas.premid.app/metadata/1.7", | |||
There was a problem hiding this comment.
| "$schema": "https://schemas.premid.app/metadata/1.7", | |
| "$schema": "https://schemas.premid.app/metadata/1.16", |
| "url": "tengoku-fansub.com", | ||
| "version": "1.0.0", | ||
| "logo": "https://i.imgur.com/TAYvhp6.png", | ||
| "thumbnail": "https://i.imgur.com/TAYvhp6.png", |
There was a problem hiding this comment.
Thumbnail should be a landscape promotional image or screenshot, not the logo
| "iframe": false, | ||
| "readLogs": false, |
There was a problem hiding this comment.
| "iframe": false, | |
| "readLogs": false, |
Unnecessary
| const showEpisode = await presence.getSetting<boolean>('showEpisode') | ||
| const showTimestamp = await presence.getSetting<boolean>('showTimestamp') | ||
| const showButtons = await presence.getSetting<boolean>('showButtons') |
There was a problem hiding this comment.
Combine using Promise.all
| const { pathname, href } = document.location | ||
|
|
||
| const presenceData: PresenceData = { | ||
| type: 3, // ActivityType.Watching |
There was a problem hiding this comment.
Use the ActivityType enum from the premid package instead
|
|
||
| presenceData.details = anime || 'Anime' | ||
| presenceData.state = 'Anime səhifəsini araşdırır' | ||
| presenceData.smallImageKey = 'browse' |
There was a problem hiding this comment.
Use image URL instead of discord asset key
|
|
||
| presenceData.details = query ? `"${query}" axtarır` : 'Arxivi axtarır' | ||
| presenceData.state = 'Tengoku Fansub' | ||
| presenceData.smallImageKey = 'search' |
There was a problem hiding this comment.
You can use Assets.Search from the Assets enumeration in the PreMiD package
| if (pathname.startsWith('/profile')) { | ||
| presenceData.details = 'Profilinə baxır' | ||
| presenceData.state = 'Tengoku Fansub' | ||
| presenceData.smallImageKey = 'browse' |
There was a problem hiding this comment.
Use image URL instead of discord asset key
| if (pathname.startsWith('/marketplace')) { | ||
| presenceData.details = 'Mağazaya baxır' | ||
| presenceData.state = 'Tengoku Fansub' | ||
| presenceData.smallImageKey = 'browse' |
There was a problem hiding this comment.
Use image URL instead of discord asset key
| // Ana səhifə / digər | ||
| presenceData.details = 'Tengoku Fansub' | ||
| presenceData.state = pathname === '/' || pathname === '' ? 'Ana səhifədə' : 'Sayta baxır' | ||
| presenceData.smallImageKey = 'logo' |
There was a problem hiding this comment.
Use image URL instead of discord asset key
theusaf
changed the title
skullysmods
left a comment
skullysmods
left a comment
There was a problem hiding this comment.
You haven't fixed the issues I reported earlier
4 participants
Description
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected