feat(Twitch): change name to be twitch while still having it show the channel name for details & state#10672
Open
S1l3ntStr1ke87 wants to merge 3 commits intoPreMiD:mainfrom
Open
feat(Twitch): change name to be twitch while still having it show the channel name for details & state#10672S1l3ntStr1ke87 wants to merge 3 commits intoPreMiD:mainfrom
S1l3ntStr1ke87 wants to merge 3 commits intoPreMiD:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…"." & "'streamerName' is assigned a value but never used. Allowed unused vars must match /^_/u."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The name is now set to Twitch instead of the streamers name, this also now uses StatusDisplayType to make sure it still shows the streamers name on details & state, this means it will work properly with lanyard-typescript-template to detect twitch
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected