Draft
Conversation
…-fails-after-counter-increment add test for failing validation of signed order after counter is incremented
…tests Dan/2023/01/add selector tests
…e-sweeping document table sweeping
…enforcement-of-conduits document revert behavior where incorrect conduit key is provided
getMetadata => getSeaportMetadata (with Schema array)
…enSea/seaport into 1.2-native-token-tests
Add HH + forge test for contract orders w native token offers
1.2 Deployment info update
add reentrancy test, wildcard consideration test
add test for additional recipients with dirty upper bits
Basic bulk signature tests
Add some tests and comment tweaks
add one last test
Get to full code coverage for Seaport 1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR highlights changes from Seaport 1.1 to Seaport 1.2 and is meant to facilitate review and discussion of those changes.